Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4602)

Unified Diff: build/config/android/rules.gni

Issue 1290643002: GN (Android): Fix packaging excess libs when target_cpu is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index f627e43699ec53c375921868f619e07dd789f2cf..3ac5c0bb3b85b66a7d6d03a3a9cc8311469b4d83 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1450,7 +1450,9 @@ template("android_apk") {
_first_ext_removed,
"$root_shlib_dir/{{source_name_part}}$shlib_extension")
- _native_libs_dir = base_path + "/libs"
+ # Add in target_cpu so that other architectures are not accidentally
+ # included when switching target_cpu without doing a clean build.
+ _native_libs_dir = gen_dir + "/lib-$target_cpu"
Dirk Pranke 2015/08/17 21:17:54 Brett, is there a better convention for toolchain-
Dirk Pranke 2015/08/19 20:14:49 Brett points out to me that this should actually b
if (_use_chromium_linker) {
_native_libs +=
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698