Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129063002: Update CSS classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, kenneth.christiansen, chromiumbugtracker_adobe.com, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update CSS classes to use OVERRIDE / FINAL when needed Update CSS classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -122 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 11 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/CSSCanvasValue.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSCharsetRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceLoadEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFaceRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSImportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMediaRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPageRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSRegionRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSRuleList.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/css/CSSStyleRule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleSheet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSSupportsRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSUnknownRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSViewportRule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/InlineVariablesIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 3 chunks +27 lines, -27 lines 0 comments Download
M Source/core/css/StyleRuleImport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/VariablesIterator.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-08 20:27:00 UTC) #1
esprehn
rslgtm
6 years, 11 months ago (2014-01-09 10:17:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/129063002/1
6 years, 11 months ago (2014-01-09 13:14:04 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 14:21:06 UTC) #4
Message was sent while issue was closed. 
Change committed as 164779

Powered by Google App Engine
This is Rietveld 408576698