Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: include/core/SkXfermode.h

Issue 12906016: Fix more clang tautological-constant-out-of-range-compare errors. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/core/SkXfermode.h
diff --git a/include/core/SkXfermode.h b/include/core/SkXfermode.h
index 0a0099f3e288766e257b2312ba2894246cde4b75..2c8b8a211379480b62b1f19deaa4517731c544bd 100644
--- a/include/core/SkXfermode.h
+++ b/include/core/SkXfermode.h
@@ -126,7 +126,10 @@ public:
kColor_Mode,
kLuminosity_Mode,
- kLastMode = kLuminosity_Mode
+ kLastMode = kLuminosity_Mode,
+ };
+ enum {
+ kModeCount = kLastMode + 1
reed1 2013/03/28 13:13:07 Why is this public now?
tfarina 2013/03/28 21:41:48 So I can use it at line 267 of SkDrawPaint.cpp xfe
};
/**
@@ -215,9 +218,6 @@ protected:
virtual SkPMColor xferColor(SkPMColor src, SkPMColor dst) const;
private:
- enum {
- kModeCount = kLastMode + 1
- };
typedef SkFlattenable INHERITED;
};

Powered by Google App Engine
This is Rietveld 408576698