Fix more clang tautological-constant-out-of-range-compare errors.

Fix more clang tautological-constant-out-of-range-compare errors.

And one of unused-private-field:
samplecode/SampleStrokeText.cpp:109:10: error: private field 'fAA' is not used [-Werror,-Wunused-private-field]
    bool fAA;

R=bsalomon@google.com,reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=8445

[reed1, 2013-03-28 13:13:07]

SampleStrokeText.cpp changes looks fine.

None of the others do.

https://codereview.chromium.org/12906016/diff/1/include/core/SkPaint.h
File include/core/SkPaint.h (right):

https://codereview.chromium.org/12906016/diff/1/include/core/SkPaint.h#newcod...
include/core/SkPaint.h:389: kDefault_Cap = kButt_Cap,
kCapCount now has the wrong value.

https://codereview.chromium.org/12906016/diff/1/include/core/SkPaint.h#newcod...
include/core/SkPaint.h:402: kDefault_Join = kMiter_Join,
kJoinCount now has the wrong value.

https://codereview.chromium.org/12906016/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/12906016/diff/1/include/core/SkXfermode.h#new...
include/core/SkXfermode.h:132: kModeCount = kLastMode + 1
Why is this public now?

https://codereview.chromium.org/12906016/diff/1/src/animator/SkDrawPaint.cpp
File src/animator/SkDrawPaint.cpp (right):

https://codereview.chromium.org/12906016/diff/1/src/animator/SkDrawPaint.cpp#...
src/animator/SkDrawPaint.cpp:227: if (style != SkPaint::kStyleCount)
For all of these changes, do you know that style (or strokeCap, etc.) is never
set to -1? This seems like a big change.

[tfarina, 2013-03-28 21:41:48]

https://codereview.chromium.org/12906016/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/12906016/diff/1/include/core/SkXfermode.h#new...
include/core/SkXfermode.h:132: kModeCount = kLastMode + 1
On 2013/03/28 13:13:07, reed1 wrote:
> Why is this public now?

So I can use it at line 267 of SkDrawPaint.cpp
xfermode != SkXfermode::kModeCount

[tfarina, 2013-03-28 21:59:51]

Does patch set 2 looks better now? Ptal.

[reed1, 2013-03-29 13:48:26]

lgtm

[commit-bot: I haz the power, 2013-03-29 13:48:37]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/12906016/14002

[commit-bot: I haz the power, 2013-03-29 13:48:38]

Presubmit check for 12906016-14002 failed and returned exit status 1.

INFO:root:Found 2 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/skia/PRESUBMIT.py

** Presubmit Warnings **
Tree state is: caution

***************
Tree is caution due to in progress M27 cherrypicks
http://skia-tree-status.appspot.com/banner-status?format=json
***************

[tfarina, 2013-03-29 16:53:57]

Committed patchset #2 manually as r8445 (presubmit successful).