Detect debugging target crash.

content/browser/devtools/render_view_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_view_devtools_agent_host.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/devtools/devtools_manager_impl.h"
 #include "content/browser/devtools/devtools_protocol.h"
+#include "content/browser/devtools/devtools_protocol_constants.h"
 #include "content/browser/devtools/renderer_overrides_handler.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/devtools_messages.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_widget_host_view.h"
@@ skipping 18 matching lines @@
     if (rvh == (*it)->render_view_host())
       return *it;
   }
   return NULL;
 }
 
 }  // namespace
 
 using WebKit::WebDevToolsAgent;
 
-class DevToolsAgentHostRvhObserver : public RenderViewHostObserver {
+class RenderViewDevToolsAgentHost::DevToolsAgentHostRvhObserver

[pfeldman, 2013/03/21 06:30:08]

Why did this change?

[Vladislav Kaznacheev, 2013/03/21 07:24:02]

yurys asked me to do that earlier in this review (see Patch Set 2). Should I
revert this?

On 2013/03/21 06:30:08, pfeldman wrote:

+    : public RenderViewHostObserver {
  public:
   DevToolsAgentHostRvhObserver(RenderViewHost* rvh,
                                RenderViewDevToolsAgentHost* agent_host)
       : RenderViewHostObserver(rvh),
         agent_host_(agent_host) {
   }
   virtual ~DevToolsAgentHostRvhObserver() {}
 
   // RenderViewHostObserver overrides.
   virtual void RenderViewHostDestroyed(RenderViewHost* rvh) OVERRIDE {
@@ skipping 202 matching lines @@
     return;
 
   if (render_view_host_ == dest_rvh && static_cast<RenderViewHostImpl*>(
           render_view_host_)->render_view_termination_status() ==
               base::TERMINATION_STATUS_STILL_RUNNING)
     return;
   DisconnectRenderViewHost();
   ConnectRenderViewHost(dest_rvh, true);
 }
 
+void RenderViewDevToolsAgentHost::RenderViewGone(
+    base::TerminationStatus status) {
+  switch(status) {
+    case base::TERMINATION_STATUS_ABNORMAL_TERMINATION:
+    case base::TERMINATION_STATUS_PROCESS_WAS_KILLED:
+    case base::TERMINATION_STATUS_PROCESS_CRASHED:
+      RenderViewCrashed();
+      break;
+    default:
+      break;
+  }
+}
+
 void RenderViewDevToolsAgentHost::ConnectRenderViewHost(RenderViewHost* rvh,
                                                         bool reattach) {
   render_view_host_ = rvh;
   rvh_observer_.reset(new DevToolsAgentHostRvhObserver(rvh, this));
   if (reattach)
     Reattach(state_);
 }
 
 void RenderViewDevToolsAgentHost::DisconnectRenderViewHost() {
   NotifyClientDetaching();
   rvh_observer_.reset();
   render_view_host_ = NULL;
 }
 
 void RenderViewDevToolsAgentHost::RenderViewHostDestroyed(
     RenderViewHost* rvh) {
   DCHECK(render_view_host_);
   scoped_refptr<RenderViewDevToolsAgentHost> protect(this);
   NotifyCloseListener();
   render_view_host_ = NULL;
   Release();
 }
 
+void RenderViewDevToolsAgentHost::RenderViewCrashed() {
+  scoped_ptr<DevToolsProtocol::Event> event(
+      DevToolsProtocol::CreateEvent(
+          devtools::Inspector::targetCrashed::kName, NULL));
+  DevToolsManagerImpl::GetInstance()->
+      DispatchOnInspectorFrontend(this, event->Serialize());
+}
+
 bool RenderViewDevToolsAgentHost::OnRvhMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderViewDevToolsAgentHost, message)
     IPC_MESSAGE_HANDLER(DevToolsClientMsg_DispatchOnInspectorFrontend,
                         OnDispatchOnInspectorFrontend)
     IPC_MESSAGE_HANDLER(DevToolsHostMsg_SaveAgentRuntimeState,
                         OnSaveAgentRuntimeState)
     IPC_MESSAGE_HANDLER(DevToolsHostMsg_ClearBrowserCache, OnClearBrowserCache)
     IPC_MESSAGE_HANDLER(DevToolsHostMsg_ClearBrowserCookies,
@@ skipping 69 matching lines @@
                             snapshot_bounds))
     return false;
 
   return base::Base64Encode(base::StringPiece(
                                 reinterpret_cast<char*>(&*png.begin()),
                                 png.size()),
                             base_64_data);
 }
 
 }  // namespace content