Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: build/android/emma_coverage_stats.py

Issue 1290593002: Changed behavior when no files require coverage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added logging statement. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/emma_coverage_stats.py
diff --git a/build/android/emma_coverage_stats.py b/build/android/emma_coverage_stats.py
index 8500890703498679c76431b0ced124cd2101bc84..89a28982243fbb64932933202a7ef182bf5c69a4 100755
--- a/build/android/emma_coverage_stats.py
+++ b/build/android/emma_coverage_stats.py
@@ -450,14 +450,15 @@ def GenerateCoverageReport(line_coverage_file, out_file_path, coverage_dir):
files_for_coverage = {f: lines
for f, lines in potential_files_for_coverage.iteritems()
if _EmmaCoverageStats.NeedsCoverage(f)}
- if not files_for_coverage:
+
+ coverage_results = {}
+ if files_for_coverage:
+ code_coverage = _EmmaCoverageStats(coverage_dir, files_for_coverage.keys())
+ coverage_results = code_coverage.GetCoverageDict(
+ files_for_coverage)
+ else:
logging.info('No Java files requiring coverage were included in %s.',
line_coverage_file)
- return
-
- code_coverage = _EmmaCoverageStats(coverage_dir, files_for_coverage.keys())
- coverage_results = code_coverage.GetCoverageDict(
- files_for_coverage)
with open(out_file_path, 'w+') as out_status_file:
json.dump(coverage_results, out_status_file)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698