Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1290593002: Changed behavior when no files require coverage. (Closed)

Created:
5 years, 4 months ago by estevenson1
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed behavior when no files require coverage. The android_coverage recipe expects a result file to be saved to the --out directory regardless of if there were files requiring code coverage or not. If no files require coverage, the script will now save an empty object to the output file instead of returning early. BUG= Committed: https://crrev.com/1167cb33649c82a33bd18f8c08333113458939ff Cr-Commit-Position: refs/heads/master@{#342957}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added logging statement. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/android/emma_coverage_stats.py View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
estevenson1
5 years, 4 months ago (2015-08-11 23:26:40 UTC) #2
mikecase (-- gone --)
lgtm with nit https://codereview.chromium.org/1290593002/diff/1/build/android/emma_coverage_stats.py File build/android/emma_coverage_stats.py (right): https://codereview.chromium.org/1290593002/diff/1/build/android/emma_coverage_stats.py#newcode459 build/android/emma_coverage_stats.py:459: nit: Add back the logging statement ...
5 years, 4 months ago (2015-08-11 23:43:55 UTC) #3
estevenson1
https://codereview.chromium.org/1290593002/diff/1/build/android/emma_coverage_stats.py File build/android/emma_coverage_stats.py (right): https://codereview.chromium.org/1290593002/diff/1/build/android/emma_coverage_stats.py#newcode459 build/android/emma_coverage_stats.py:459: On 2015/08/11 at 23:43:55, mikecase wrote: > nit: Add ...
5 years, 4 months ago (2015-08-11 23:48:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290593002/20001
5 years, 4 months ago (2015-08-11 23:48:50 UTC) #7
jbudorick
lgtm
5 years, 4 months ago (2015-08-12 01:17:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290593002/20001
5 years, 4 months ago (2015-08-12 01:18:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 01:28:38 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 01:29:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1167cb33649c82a33bd18f8c08333113458939ff
Cr-Commit-Position: refs/heads/master@{#342957}

Powered by Google App Engine
This is Rietveld 408576698