Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animations.js

Issue 1290583002: Settings: Implement sub-subpages, and clean up some animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify further. fixes display artifact. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page/settings_animations.js
diff --git a/chrome/browser/resources/settings/settings_page/settings_animations.js b/chrome/browser/resources/settings/settings_page/settings_animations.js
deleted file mode 100644
index 2c08c0ac55024947bbcfa21f45edf485754887be..0000000000000000000000000000000000000000
--- a/chrome/browser/resources/settings/settings_page/settings_animations.js
+++ /dev/null
@@ -1,51 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview
- * This file defines a set of common animations used by
- * 'settings-animated-pages'.
- */
-Polymer({
- is: 'next-page-enter-animation',
-
- behaviors: [
- Polymer.NeonAnimationBehavior
- ],
-
- configure: function(config) {
- var node = config.node;
-
- var timing = this.timingFromConfig(config);
- timing.delay = 150;
- timing.duration = 150;
tommycli 2015/08/12 19:15:19 Do we are about the specific timing? If we are fin
Dan Beam 2015/08/12 21:38:04 we may care.
tommycli 2015/08/12 22:11:57 Okay. I undeleted this file then.
-
- this._effect = new KeyframeEffect(node, [
- {'opacity': '0'},
- {'opacity': '1'}
- ], timing);
- return this._effect;
- }
-});
-
-Polymer({
- is: 'next-page-exit-animation',
-
- behaviors: [
- Polymer.NeonAnimationBehavior
- ],
-
- configure: function(config) {
- var node = config.node;
-
- var timing = this.timingFromConfig(config);
- timing.duration = 150;
-
- this._effect = new KeyframeEffect(node, [
- {'opacity': '1'},
- {'opacity': '0'}
- ], timing);
- return this._effect;
- }
-});

Powered by Google App Engine
This is Rietveld 408576698