Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290553005: Add include paths in gputest.gyp for use by additional gpu tests. (Closed)

Created:
5 years, 4 months ago by egdaniel
Modified:
5 years, 4 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add include paths in gputest.gyp for use by additional gpu tests. BUG=skia: Committed: https://skia.googlesource.com/skia/+/540e4888a58c2c82e0de83753d58509c5350c6c6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M gyp/gpu.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M gyp/gputest.gyp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
egdaniel
https://codereview.chromium.org/1290553005/diff/1/gyp/gputest.gyp File gyp/gputest.gyp (right): https://codereview.chromium.org/1290553005/diff/1/gyp/gputest.gyp#newcode16 gyp/gputest.gyp:16: '../include/gpu', I think technically we could also get rid ...
5 years, 4 months ago (2015-08-14 15:25:59 UTC) #2
jvanverth1
lgtm
5 years, 4 months ago (2015-08-14 15:29:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290553005/1
5 years, 4 months ago (2015-08-14 15:31:11 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 15:37:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/540e4888a58c2c82e0de83753d58509c5350c6c6

Powered by Google App Engine
This is Rietveld 408576698