[refactor] Extract some test helpers for certificate verification unittests.

[refactor] Extract some test helpers for certificate verification unittests.

These functions are re-used further in upcoming changelists.

BUG=410574
Committed: https://crrev.com/8a4ad9464e5daeb6d193ac0388d2c4806111ad69
Cr-Commit-Position: refs/heads/master@{#343149}

[eroman, 2015-08-11 22:43:44]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[eroman, 2015-08-11 22:43:44]

@mattm: As reviewer

@davidben: Just FYI since I will re-use this in the other CLs you are reviewing:

Context:

I found myself reaching for these primitives in:
  https://codereview.chromium.org/1279963003/
  https://codereview.chromium.org/1285593003/

So figured I would extract it.

Also plan to move GTest equality/printing for der::Input into there (introduced
by another CL).

[mattm, 2015-08-12 21:30:27]

lgtm

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
File net/cert/internal/verify_name_match_unittest.cc (right):

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
net/cert/internal/verify_name_match_unittest.cc:17: der::Input
SequenceValueFromString(const std::string& s) {
Do you want to update this to also take a pointer instead of a reference, or
should I do that in a separate CL?

[eroman, 2015-08-12 21:51:30]

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
File net/cert/internal/verify_name_match_unittest.cc (right):

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
net/cert/internal/verify_name_match_unittest.cc:17: der::Input
SequenceValueFromString(const std::string& s) {
On 2015/08/12 21:30:26, mattm wrote:
> Do you want to update this to also take a pointer instead of a reference, or
> should I do that in a separate CL?

Good point!
I will make that change in this CL.

[eroman, 2015-08-12 22:51:00]

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
File net/cert/internal/verify_name_match_unittest.cc (right):

https://codereview.chromium.org/1290553002/diff/20001/net/cert/internal/verif...
net/cert/internal/verify_name_match_unittest.cc:17: der::Input
SequenceValueFromString(const std::string& s) {
On 2015/08/12 21:51:30, eroman wrote:
> On 2015/08/12 21:30:26, mattm wrote:
> > Do you want to update this to also take a pointer instead of a reference, or
> > should I do that in a separate CL?
> 
> Good point!
> I will make that change in this CL.

Done.

[mattm, 2015-08-12 23:45:55]

lgtm

[eroman, 2015-08-13 00:39:49]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-08-13 00:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-13 00:40:04]

This CL has an open dependency (Issue 1238413004 Patch 60001). Please resolve
the dependency and try again.

[eroman, 2015-08-13 00:48:06]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-08-13 00:48:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1290553002/#ps60001
(title: "rebase onto master")

[commit-bot: I haz the power, 2015-08-13 00:48:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290553002/60001

[commit-bot: I haz the power, 2015-08-13 02:04:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-13 02:04:46]

Patchset 4 (id:??) landed as
https://crrev.com/8a4ad9464e5daeb6d193ac0388d2c4806111ad69
Cr-Commit-Position: refs/heads/master@{#343149}