Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1224)

Unified Diff: remoting/webapp/session_connector.js

Issue 12905012: Webapp changes to support third party authentication (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/session_connector.js
diff --git a/remoting/webapp/session_connector.js b/remoting/webapp/session_connector.js
index 994746d50478da2712bd515f9964055a9f454b4f..2e4c7dddaa3554e3f6198f862485117eec4b9cd7 100644
--- a/remoting/webapp/session_connector.js
+++ b/remoting/webapp/session_connector.js
@@ -137,6 +137,7 @@ remoting.SessionConnector = function(pluginParent, onOk, onError) {
remoting.SessionConnector.prototype.connectMe2Me = function(host, fetchPin) {
this.hostId_ = host.hostId;
this.hostJid_ = host.jabberId;
+ this.hostPublicKey_ = host.publicKey;
Jamie 2013/03/28 23:29:36 This feels like it should be a separate fix. Is it
rmsousa 2013/03/29 04:08:21 Yes. Aside from ThirdPartyAuth, hostPublicKey is j
Jamie 2013/03/29 18:19:24 Generally, things like this should be in a separat
this.fetchPin_ = fetchPin;
this.hostDisplayName_ = host.hostName;
this.createSessionIfReady_();
@@ -274,7 +275,7 @@ remoting.SessionConnector.prototype.createSessionIfReady_ = function() {
return;
}
- var securityTypes = 'spake2_hmac,spake2_plain';
+ var securityTypes = 'third_party,spake2_hmac,spake2_plain';
this.clientSession_ = new remoting.ClientSession(
this.hostJid_, this.clientJid_, this.hostPublicKey_, this.passPhrase_,
this.fetchPin_, securityTypes, this.hostId_, this.connectionMode_,

Powered by Google App Engine
This is Rietveld 408576698