Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: src/handles.h

Issue 1290453002: Realize IWYU pattern for handles.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/futex-emulation.h ('k') | src/i18n.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/handles.h
diff --git a/src/handles.h b/src/handles.h
index 841a83ba6044f81a7bc418792fcf3465b0eab38b..2db18307dacad563b89a5ba3eea179eb43b9b85e 100644
--- a/src/handles.h
+++ b/src/handles.h
@@ -5,7 +5,10 @@
#ifndef V8_HANDLES_H_
#define V8_HANDLES_H_
-#include "src/objects.h"
+#include "include/v8.h"
+#include "src/base/macros.h"
+#include "src/checks.h"
+#include "src/globals.h"
namespace v8 {
namespace internal {
@@ -13,6 +16,8 @@ namespace internal {
// Forward declarations.
class DeferredHandles;
class HandleScopeImplementer;
+class Isolate;
+class Object;
// ----------------------------------------------------------------------------
@@ -25,9 +30,9 @@ class HandleBase {
// Check if this handle refers to the exact same object as the other handle.
V8_INLINE bool is_identical_to(const HandleBase that) const {
// Dereferencing deferred handles to check object equality is safe.
- SLOW_DCHECK((this->location_ == NULL ||
+ SLOW_DCHECK((this->location_ == nullptr ||
this->IsDereferenceAllowed(NO_DEFERRED_CHECK)) &&
- (that.location_ == NULL ||
+ (that.location_ == nullptr ||
that.IsDereferenceAllowed(NO_DEFERRED_CHECK)));
if (this->location_ == that.location_) return true;
if (this->location_ == NULL || that.location_ == NULL) return false;
@@ -45,7 +50,7 @@ class HandleBase {
// Returns the address to where the raw pointer is stored.
V8_INLINE Object** location() const {
- SLOW_DCHECK(location_ == NULL ||
+ SLOW_DCHECK(location_ == nullptr ||
IsDereferenceAllowed(INCLUDE_DEFERRED_CHECK));
return location_;
}
« no previous file with comments | « src/futex-emulation.h ('k') | src/i18n.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698