Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290453002: Realize IWYU pattern for handles.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Realize IWYU pattern for handles.h header. R=bmeurer@chromium.org Committed: https://crrev.com/a8fba0f62efdbac6dae069b0308f74ee560752ca Cr-Commit-Position: refs/heads/master@{#30110}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M src/accessors.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/api-natives.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/futex-emulation.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/handles.h View 4 chunks +9 lines, -4 lines 0 comments Download
M src/i18n.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/messages.h View 1 1 chunk +5 lines, -23 lines 0 comments Download
M src/string-stream.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-11 11:26:54 UTC) #1
Benedikt Meurer
Love it. LGTM!
5 years, 4 months ago (2015-08-11 11:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290453002/20001
5 years, 4 months ago (2015-08-11 11:44:04 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 12:00:06 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 12:00:33 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a8fba0f62efdbac6dae069b0308f74ee560752ca
Cr-Commit-Position: refs/heads/master@{#30110}

Powered by Google App Engine
This is Rietveld 408576698