Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290383005: use more specific variables in net/BUILD.gn (Closed)

Created:
5 years, 4 months ago by Mostyn Bramley-Moore
Modified:
5 years, 4 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use more specific variables in net/BUILD.gn Committed: https://crrev.com/1de43a2a3a24d42bebce517dac1a9a06746e9826 Cr-Commit-Position: refs/heads/master@{#344492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M net/BUILD.gn View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290383005/1
5 years, 4 months ago (2015-08-20 13:20:33 UTC) #2
Mostyn Bramley-Moore
@Elly: please take a look at this tiny gn change...
5 years, 4 months ago (2015-08-20 13:21:05 UTC) #4
Elly Fong-Jones
lgtm
5 years, 4 months ago (2015-08-20 13:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290383005/1
5 years, 4 months ago (2015-08-20 13:43:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 13:52:45 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 13:53:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1de43a2a3a24d42bebce517dac1a9a06746e9826
Cr-Commit-Position: refs/heads/master@{#344492}

Powered by Google App Engine
This is Rietveld 408576698