Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290383003: Fix more sign comparison errors. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -51 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 2 chunks +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 4 chunks +21 lines, -16 lines 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 7 chunks +19 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Lei Zhang
5 years, 4 months ago (2015-08-17 17:42:56 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1290383003/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1290383003/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode103 core/include/fpdfapi/fpdf_resource.h:103: static const FX_DWORD kInvalidCharCode = static_cast<FX_DWORD>(-1); nit: Does ...
5 years, 4 months ago (2015-08-17 18:44:43 UTC) #3
Tom Sepez
On 2015/08/17 18:44:43, Tom Sepez wrote: > lgtm > > https://codereview.chromium.org/1290383003/diff/1/core/include/fpdfapi/fpdf_resource.h > File core/include/fpdfapi/fpdf_resource.h (right): ...
5 years, 4 months ago (2015-08-17 19:17:17 UTC) #4
Tom Sepez
https://codereview.chromium.org/1290383003/diff/1/fpdfsdk/src/javascript/PublicMethods.cpp File fpdfsdk/src/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/1290383003/diff/1/fpdfsdk/src/javascript/PublicMethods.cpp#newcode1499 fpdfsdk/src/javascript/PublicMethods.cpp:1499: ASSERT(iIndex < FX_ArraySize(cFormats)); Nit: do we need to assert ...
5 years, 4 months ago (2015-08-17 19:18:04 UTC) #5
Lei Zhang
https://codereview.chromium.org/1290383003/diff/1/fpdfsdk/src/javascript/PublicMethods.cpp File fpdfsdk/src/javascript/PublicMethods.cpp (right): https://codereview.chromium.org/1290383003/diff/1/fpdfsdk/src/javascript/PublicMethods.cpp#newcode1499 fpdfsdk/src/javascript/PublicMethods.cpp:1499: ASSERT(iIndex < FX_ArraySize(cFormats)); On 2015/08/17 19:18:03, Tom Sepez wrote: ...
5 years, 4 months ago (2015-08-17 19:19:28 UTC) #6
Lei Zhang
5 years, 4 months ago (2015-08-17 19:20:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9494421208674d2c57a9f864d342f017c0b20902 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698