tracing/tracing/extras/chrome/chrome_browser_helper.html - Issue 1290323003: Create a mapper to compute browser and renderer startup durations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/extras/chrome/chrome_browser_helper.html

Issue 1290323003: Create a mapper to compute browser and renderer startup durations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Answered nits. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/extras/chrome/chrome_browser_helper.html

diff --git a/tracing/tracing/extras/chrome/chrome_browser_helper.html b/tracing/tracing/extras/chrome/chrome_browser_helper.html

index 46b00bd5c9189e959a57a7a859a8f323d4b9407c..7bee717cfebd4829c74a9bc905c5f602fe960afa 100644

--- a/tracing/tracing/extras/chrome/chrome_browser_helper.html

+++ b/tracing/tracing/extras/chrome/chrome_browser_helper.html

@@ -20,9 +20,7 @@ tr.exportTo('tr.e.audits', function() {

}

ChromeBrowserHelper.isBrowserProcess = function(process) {

- if (!process.findAtMostOneThreadNamed('CrBrowserMain'))

- return false;

- return true;

+ return !!process.findAtMostOneThreadNamed('CrBrowserMain');

};

ChromeBrowserHelper.prototype = {

« no previous file with comments | « perf_insights/perf_insights_examples/map_startup_info_test.html ('k') | tracing/tracing/model/thread.html » ('j') | no next file with comments »