Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: tracing/tracing/extras/rail/rail_ir_finder.html

Issue 1290323003: Create a mapper to compute browser and renderer startup durations. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/extras/rail/rail_ir_finder.html
diff --git a/tracing/tracing/extras/rail/rail_ir_finder.html b/tracing/tracing/extras/rail/rail_ir_finder.html
index d8ddb6939ce406045678a326355751a4cf1581bb..4a718653b56cd3cdeade2a172926e81c7ececb6b 100644
--- a/tracing/tracing/extras/rail/rail_ir_finder.html
+++ b/tracing/tracing/extras/rail/rail_ir_finder.html
@@ -135,6 +135,13 @@ tr.exportTo('tr.e.rail', function() {
return rirs;
},
+ setIRNames_: function(name, irs) {
+ irs.forEach(function(ir) {
dsinclair 2015/08/14 13:18:34 This is from a different CL, should it be removed
beaudoin 2015/08/14 20:28:54 Yup, it's gone. This was a git branch on a git br
+ ir.args['name'] = name;
+ });
+ return irs;
+ },
+
// Find all unassociated top-level ThreadSlices. If they start during an
// Idle or Load IR, then add their entire hierarchy to that IR.
collectUnassociatedEvents_: function(rirs) {
@@ -277,16 +284,16 @@ tr.exportTo('tr.e.rail', function() {
var lirs = [];
// Attach frame events to every main runner events.
- lirs.push.apply(lirs, this.findLoadInteractionRecords_(mainRunnerEvents,
- frameEvents));
+ lirs.push.apply(lirs, this.setIRNames_('Startup',
+ this.findLoadInteractionRecords_(mainRunnerEvents, frameEvents)));
// Attach frame events to every commit load events.
- lirs.push.apply(lirs, this.findLoadInteractionRecords_(commitLoadEvents,
- frameEvents));
+ lirs.push.apply(lirs, this.setIRNames_('Succeeded',
+ this.findLoadInteractionRecords_(commitLoadEvents, frameEvents)));
// Attach fail load events to every start load events.
- lirs.push.apply(lirs, this.findLoadInteractionRecords_(startLoadEvents,
- failLoadEvents));
+ lirs.push.apply(lirs, this.setIRNames_('Failed',
+ this.findLoadInteractionRecords_(startLoadEvents, failLoadEvents)));
return lirs;
},

Powered by Google App Engine
This is Rietveld 408576698