Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290323002: HTMLViewer no longer connects to NetworkService interface. (Closed)

Created:
5 years, 4 months ago by Ben Goodger (Google)
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLViewer no longer connects to NetworkService interface. R=jam@chromium.org http://crbug.com/510210 Committed: https://crrev.com/bca21f398390f9f2fad65393ced5c6fa2569509f Cr-Commit-Position: refs/heads/master@{#343348}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -96 lines) Patch
M components/html_viewer/blink_platform_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_socket_handle_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mandoline/tab/frame_connection.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/mojo_services.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 4 chunks +4 lines, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 4 chunks +28 lines, -19 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 2 6 chunks +36 lines, -22 lines 0 comments Download
M mojo/services/network/network_service_impl.h View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 2 1 chunk +1 line, -16 lines 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +2 lines, -7 lines 0 comments Download
A + mojo/services/network/public/interfaces/web_socket_factory.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/url_loader_factory_impl.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/network/url_loader_factory_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A mojo/services/network/web_socket_factory_impl.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A mojo/services/network/web_socket_factory_impl.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ben Goodger (Google)
Ostensibly this means the html viewer can no longer do anything dangerous.
5 years, 4 months ago (2015-08-14 03:36:25 UTC) #1
jam
lgtm
5 years, 4 months ago (2015-08-14 05:18:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290323002/40001
5 years, 4 months ago (2015-08-14 05:50:06 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-14 06:37:12 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 06:38:03 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bca21f398390f9f2fad65393ced5c6fa2569509f
Cr-Commit-Position: refs/heads/master@{#343348}

Powered by Google App Engine
This is Rietveld 408576698