Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: runtime/vm/simulator_mips.h

Issue 12903006: Drops into Simulator Debugger only in a session that is already interactive. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/simulator_mips.h
===================================================================
--- runtime/vm/simulator_mips.h (revision 20300)
+++ runtime/vm/simulator_mips.h (working copy)
@@ -96,6 +96,19 @@
// Read and write memory.
void UnalignedAccess(const char* msg, uword addr, Instr* instr);
+ // Handles a legal instruction that the simulator does not implement.
+ void UnimplementedInstruction(Instr* instr);
+
+ // If something goes wrong (Unimplemented instruction, illegal access, etc.),
+ // this flag is used to decide whether to die or to drop into the simulator
+ // debugger. Its initial value is false. Then, when we enter the simulator
+ // debugger (for a user set breakpoint, etc.) it is set to true.
+ bool debugger_attached_;
+
+ // Accesors to set and check whether the simulator debugger is attached.
regis 2013/03/21 17:21:13 Accessors
zra 2013/03/21 17:48:52 Done.
+ bool debugger_attached() const { return debugger_attached_; }
+ void set_debugger_attached(bool b) { debugger_attached_ = b; }
+
bool OverflowFrom(int32_t alu_out,
int32_t left,
int32_t right,

Powered by Google App Engine
This is Rietveld 408576698