Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/profiler_test.cc

Issue 1290273005: Relax symbol match on Windows (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_test.cc
diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc
index 1efc6b1cf26316f80fb96678ce4b5b8e202da4b5..e9017d89cc45f8baca286bf74ecbee5584f4250b 100644
--- a/runtime/vm/profiler_test.cc
+++ b/runtime/vm/profiler_test.cc
@@ -816,7 +816,12 @@ TEST_CASE(Profiler_ClassAllocation) {
walker.Reset(Profile::kExclusiveCode);
EXPECT(walker.Down());
+#if defined(TARGET_OS_WINDOWS)
+ // TODO(johnmccutchan): Hookup native symbol resolver on Windows.
+ EXPECT_SUBSTRING("[Native]", walker.CurrentName());
+#else
EXPECT_SUBSTRING("dart::Profiler::RecordAllocation", walker.CurrentName());
+#endif
EXPECT(!walker.Down());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698