net/http/http_stream_factory_impl_unittest.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Sync'd to revision p347709. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/shell_url_request_context_getter.cc ('K') | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/proxy/proxy_script_fetcher_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_impl_unittest.cc

diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc

index 11cf98d1bd0cffa08176d323954eae4e135d22e9..864c46e57bb461281b5cd875cad756bfca058fbf 100644

--- a/net/http/http_stream_factory_impl_unittest.cc

+++ b/net/http/http_stream_factory_impl_unittest.cc

@@ -619,8 +619,8 @@ TEST_P(HttpStreamFactoryTest, UnreachableQuicProxyMarkedAsBad) {

i == 1 ? ERR_QUIC_PROTOCOL_ERROR : ERR_QUIC_HANDSHAKE_FAILED;

scoped_ptr<ProxyService> proxy_service;

- proxy_service.reset(

- ProxyService::CreateFixedFromPacResult("QUIC bad:99; DIRECT"));

+ proxy_service =

+ ProxyService::CreateFixedFromPacResult("QUIC bad:99; DIRECT");

HttpNetworkSession::Params params;

params.enable_quic = true;

@@ -681,8 +681,7 @@ TEST_P(HttpStreamFactoryTest, UnreachableQuicProxyMarkedAsBad) {

TEST_P(HttpStreamFactoryTest, QuicLossyProxyMarkedAsBad) {

// Checks if a

scoped_ptr<ProxyService> proxy_service;

- proxy_service.reset(

- ProxyService::CreateFixedFromPacResult("QUIC bad:99; DIRECT"));

+ proxy_service = ProxyService::CreateFixedFromPacResult("QUIC bad:99; DIRECT");

HttpNetworkSession::Params params;

params.enable_quic = true;