components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Sync'd to revision p347709. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('k') | content/browser/renderer_host/pepper/ssl_context_helper.cc » ('j') | content/shell/browser/layout_test/layout_test_url_request_context_getter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

index 8993d66d6a5823bcc7c398a958da1f77c207da28..fa0f241d18cbe3d5ba9e0e165e7a1c8c236b1408 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

@@ -529,16 +529,16 @@ void DataReductionProxyTestContext::AttachToURLRequestContext(

// |request_context_storage| takes ownership of the network delegate.

request_context_storage->set_network_delegate(

- io_data()->CreateNetworkDelegate(

- scoped_ptr<net::NetworkDelegate>(new net::TestNetworkDelegate()),

- true).release());

+ io_data()

+ ->CreateNetworkDelegate(

+ make_scoped_ptr(new net::TestNetworkDelegate()).Pass(), true)

+ .Pass());

- // |request_context_storage| takes ownership of the job factory.

request_context_storage->set_job_factory(

- new net::URLRequestInterceptingJobFactory(

+ make_scoped_ptr(new net::URLRequestInterceptingJobFactory(

scoped_ptr<net::URLRequestJobFactory>(

new net::URLRequestJobFactoryImpl()),

- io_data()->CreateInterceptor().Pass()));

+ io_data()->CreateInterceptor().Pass())));

}

void DataReductionProxyTestContext::