components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Sync'd to revision p347709. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc » ('j') | content/shell/browser/layout_test/layout_test_url_request_context_getter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

index 145b26778864ddd32b35acfe3971b9957d773e43..4492a870a0e6ac2945f5a1b93ef9e0c6af060fbe 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

@@ -210,9 +210,8 @@ class DataReductionProxyInterceptorWithServerTest : public testing::Test {

proxies_for_http.push_back(origin);

test_context_->config()->test_params()->SetProxiesForHttp(proxies_for_http);

std::string proxy_name = origin.ToURI();

- proxy_service_.reset(

- net::ProxyService::CreateFixedFromPacResult(

- "PROXY " + proxy_name + "; DIRECT"));

+ proxy_service_ = net::ProxyService::CreateFixedFromPacResult(

+ "PROXY " + proxy_name + "; DIRECT");

context_.set_proxy_service(proxy_service_.get());