net/http/http_auth_handler_factory.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_factory.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Lots of fixes driven by try jobs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('K') | « net/http/http_auth_handler_factory.h ('k') | net/http/http_network_layer_unittest.cc » ('j') | net/http/http_stream_factory_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_auth_handler_factory.cc

diff --git a/net/http/http_auth_handler_factory.cc b/net/http/http_auth_handler_factory.cc

index b148aad149e9f2f33a3fe41f130d967b0d7a93f4..5a89964a80c6d47344e6ab2daa747a92b30b3305 100644

--- a/net/http/http_auth_handler_factory.cc

+++ b/net/http/http_auth_handler_factory.cc

@@ -43,11 +43,11 @@ int HttpAuthHandlerFactory::CreatePreemptiveAuthHandlerFromString(

}

// static

-HttpAuthHandlerRegistryFactory* HttpAuthHandlerFactory::CreateDefault(

- HostResolver* host_resolver) {

+scoped_ptr<HttpAuthHandlerRegistryFactory>

+HttpAuthHandlerFactory::CreateDefault(HostResolver* host_resolver) {

DCHECK(host_resolver);

- HttpAuthHandlerRegistryFactory* registry_factory =

- new HttpAuthHandlerRegistryFactory();

+ scoped_ptr<HttpAuthHandlerRegistryFactory> registry_factory =

+ make_scoped_ptr(new HttpAuthHandlerRegistryFactory());

registry_factory->RegisterSchemeFactory(

"basic", new HttpAuthHandlerBasic::Factory());

registry_factory->RegisterSchemeFactory(