net/cert/cert_verifier.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verifier.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Lots of fixes driven by try jobs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('K') | « net/cert/cert_verifier.h ('k') | net/cert_net/cert_net_fetcher_impl_unittest.cc » ('j') | net/http/http_stream_factory_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/cert_verifier.cc

diff --git a/net/cert/cert_verifier.cc b/net/cert/cert_verifier.cc

index 4152d55e583255d7c11383000688cafab6ec9349..98d185b800422752cd6544ef4bb2e8b26be0de14 100644

--- a/net/cert/cert_verifier.cc

+++ b/net/cert/cert_verifier.cc

@@ -19,12 +19,13 @@ bool CertVerifier::SupportsOCSPStapling() {

return false;

}

-CertVerifier* CertVerifier::CreateDefault() {

+scoped_ptr<CertVerifier> CertVerifier::CreateDefault() {

#if defined(OS_NACL)

NOTIMPLEMENTED();

- return nullptr;

+ return scoped_ptr<CertVerifier>();

#else

- return new MultiThreadedCertVerifier(CertVerifyProc::CreateDefault());

+ return scoped_ptr<CertVerifier>(

+ new MultiThreadedCertVerifier(CertVerifyProc::CreateDefault()));

#endif

}