content/shell/browser/layout_test/layout_test_url_request_context_getter.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Lots of fixes driven by try jobs. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc ('K') | « content/shell/browser/layout_test/layout_test_url_request_context_getter.h ('k') | content/shell/browser/shell_url_request_context_getter.h » ('j') | net/http/http_stream_factory_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

diff --git a/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

index 15ddd806ae08b38094124192db0851fa545b6877..27732b34165b1ec9d385c4f49f2354c197d065ba 100644

--- a/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

+++ b/content/shell/browser/layout_test/layout_test_url_request_context_getter.cc

@@ -34,18 +34,19 @@ LayoutTestURLRequestContextGetter::LayoutTestURLRequestContextGetter(

LayoutTestURLRequestContextGetter::~LayoutTestURLRequestContextGetter() {

}

-net::NetworkDelegate*

+scoped_ptr<net::NetworkDelegate>

LayoutTestURLRequestContextGetter::CreateNetworkDelegate() {

ShellNetworkDelegate::SetAcceptAllCookies(false);

- return new ShellNetworkDelegate;

+ return make_scoped_ptr(new ShellNetworkDelegate);

}

-net::ProxyConfigService*

+scoped_ptr<net::ProxyConfigService>

LayoutTestURLRequestContextGetter::GetProxyConfigService() {

- return nullptr;

+ return scoped_ptr<net::ProxyConfigService>();

}

-net::ProxyService* LayoutTestURLRequestContextGetter::GetProxyService() {

+scoped_ptr<net::ProxyService>

+LayoutTestURLRequestContextGetter::GetProxyService() {

return net::ProxyService::CreateDirect();

}