Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: build/gyp_chromium

Issue 129023002: Remove extra print statemt from GYP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This script is wrapper for Chromium that adds some support for how GYP 7 # This script is wrapper for Chromium that adds some support for how GYP
8 # is invoked by Chromium beyond what can be done in the gclient hooks. 8 # is invoked by Chromium beyond what can be done in the gclient hooks.
9 9
10 import glob 10 import glob
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 cmdline_items = ProcessGypDefinesItems(cmdline_input_items) 123 cmdline_items = ProcessGypDefinesItems(cmdline_input_items)
124 124
125 return dict(supp_items + env_items + cmdline_items) 125 return dict(supp_items + env_items + cmdline_items)
126 126
127 127
128 def GetArgsStringForGN(supplemental_files): 128 def GetArgsStringForGN(supplemental_files):
129 """Returns the args to pass to GN. 129 """Returns the args to pass to GN.
130 Based on a subset of the GYP variables that have been rewritten a bit.""" 130 Based on a subset of the GYP variables that have been rewritten a bit."""
131 131
132 vars_dict = GetGypVarsForGN(supplemental_files) 132 vars_dict = GetGypVarsForGN(supplemental_files)
133 print vars_dict
134 gn_args = '' 133 gn_args = ''
135 134
136 # Note: These are the additional flags passed to various builds by builders 135 # Note: These are the additional flags passed to various builds by builders
137 # on the main waterfall. We'll probably need to add these at some point: 136 # on the main waterfall. We'll probably need to add these at some point:
138 # mac_strip_release=1 http://crbug.com/330301 137 # mac_strip_release=1 http://crbug.com/330301
139 # linux_dump_symbols=0 http://crbug.com/330300 138 # linux_dump_symbols=0 http://crbug.com/330300
140 # host_os=linux Probably can skip, GN knows the host OS. 139 # host_os=linux Probably can skip, GN knows the host OS.
141 # gcc_version=46 Hopefully we can skip this and fix whatever uses it. 140 # gcc_version=46 Hopefully we can skip this and fix whatever uses it.
142 # order_text_section=<path> http://crbug.com/330299 141 # order_text_section=<path> http://crbug.com/330299
143 # chromium_win_pch=0 http://crbug.com/297678 142 # chromium_win_pch=0 http://crbug.com/297678
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 # to enfore syntax checking. 366 # to enfore syntax checking.
368 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK') 367 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
369 if syntax_check and int(syntax_check): 368 if syntax_check and int(syntax_check):
370 args.append('--check') 369 args.append('--check')
371 370
372 print 'Updating projects from gyp files...' 371 print 'Updating projects from gyp files...'
373 sys.stdout.flush() 372 sys.stdout.flush()
374 373
375 # Off we go... 374 # Off we go...
376 sys.exit(gyp.main(args)) 375 sys.exit(gyp.main(args))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698