Issue 1290223005: Try enabling all nanobenches on Nexus7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290223005: Try enabling all nanobenches on Nexus7 (Closed)

Created:
5 years, 4 months ago by egdaniel

Modified:
5 years, 4 months ago

Reviewers:
mtklein, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Try enabling all nanobenches on Nexus7 BUG=skia:2774 Committed: https://skia.googlesource.com/skia/+/73caadf277248576c2df101cf2a63c78db8096a5

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/nanobench_flags.json	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	tools/nanobench_flags.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

egdaniel

Anyone have any objections about trying to reenable these? I'm not sure what was failing ...

5 years, 4 months ago (2015-08-18 19:55:30 UTC) #2

bsalomon

On 2015/08/18 19:55:30, egdaniel wrote: > Anyone have any objections about trying to reenable these? ...

5 years, 4 months ago (2015-08-18 19:59:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290223005/1

5 years, 4 months ago (2015-08-18 20:02:08 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-18 20:08:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/73caadf277248576c2df101cf2a63c78db8096a5

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages