Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/test.dart

Issue 12902035: Added --failure-summary option to test.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index d3f07b8baeb0e19135ce322f83658626f9c2b039..f39518ac14790d7fbac4a48b21096461f3f02080 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -78,6 +78,7 @@ void testConfigurations(List<Map> configurations) {
Map<String, RegExp> selectors = firstConf['selectors'];
var maxProcesses = firstConf['tasks'];
var progressIndicator = firstConf['progress'];
+ var failureSummary = firstConf['failure-summary'];
BuildbotProgressIndicator.stepName = firstConf['step_name'];
var verbose = firstConf['verbose'];
var printTiming = firstConf['time'];
@@ -191,7 +192,11 @@ void testConfigurations(List<Map> configurations) {
eventListener.add(new SummaryPrinter());
eventListener.add(new FlakyLogWriter());
if (printFailures) {
- eventListener.add(new TestFailurePrinter(formatter));
+ // The buildbot has it's own failure summary since it needs to wrap it
+ // into'@@@'-annotated sections.
+ var printFaiureSummary =
+ failureSummary && progressIndicator != 'buildbot';
+ eventListener.add(new TestFailurePrinter(printFaiureSummary, formatter));
}
eventListener.add(new ProgressIndicator.fromName(progressIndicator,
startTime,
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698