Auto-generates the font family scripts at build time.

chrome/browser/ui/prefs/prefs_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/prefs/prefs_tab_helper.h"
 
 #include <string>
 
 #include "base/prefs/overlay_user_pref_store.h"
 #include "base/prefs/pref_service.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/pref_font_webkit_names.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_names_util.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/locale_settings.h"
 #include "grit/platform_locale_settings.h"
 #include "third_party/icu/public/common/unicode/uchar.h"
@@ skipping 87 matching lines @@
   prefs::kWebKitPluginsEnabled,
   prefs::kWebkitTabsToLinks,
   prefs::kWebKitUsesUniversalDetector
 };
 
 const int kPrefsToObserveLength = arraysize(kPrefsToObserve);
 
 // Registers a preference under the path |map_name| for each script used for
 // per-script font prefs.  For example, if |map_name| is "fonts.serif", then
 // "fonts.serif.Arab", "fonts.serif.Hang", etc. are registered.
 void RegisterFontFamilyMap(PrefRegistrySyncable* registry,

[falken, 2013/03/19 18:26:04]

Can you update this comment and change the function name to reflect what it does
now? Like "RegisterFontFamilyPrefs". Maybe also add a comment about what
|fonts_with_defaults| does (there should have been one before).

[bulach, 2013/03/20 11:01:27]

Done.

-                           const char* map_name,
                            const std::set<std::string>& fonts_with_defaults) {
-  for (size_t i = 0; i < prefs::kWebKitScriptsForFontFamilyMapsLength; ++i) {
-    const char* script = prefs::kWebKitScriptsForFontFamilyMaps[i];
-    std::string pref_name_str = base::StringPrintf("%s.%s", map_name, script);
-    const char* pref_name = pref_name_str.c_str();
+
+  // Expand the font concatenated with script name so this stays at RO memory
+  // rather than allocated in heap.
+  static const char* const kFontFamilyMap[] = {
+#define EXPAND_SCRIPT_FONT(map_name, script_name) map_name "." script_name,
+
+#include "chrome/common/pref_font_script_names-inl.h"
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_CURSIVE)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_FANTASY)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_FIXED)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_PICTOGRAPH)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_SANSERIF)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_SERIF)
+ALL_FONT_SCRIPTS(WEBKIT_WEBPREFS_FONTS_STANDARD)
+
+#undef EXPAND_SCRIPT_FONT
+  };
+
+  for (size_t i = 0; i < arraysize(kFontFamilyMap); ++i) {
+    const char* pref_name = kFontFamilyMap[i];
     if (fonts_with_defaults.find(pref_name) == fonts_with_defaults.end()) {
       // We haven't already set a default value for this font preference, so set
       // an empty string as the default.
       registry->RegisterStringPref(
           pref_name, "", PrefRegistrySyncable::UNSYNCABLE_PREF);
     }
   }
 }
 
 #if !defined(OS_ANDROID)
@@ skipping 397 matching lines @@
     if (browser_script != pref_script) {
       registry->RegisterLocalizedStringPref(
           pref.pref_name,
           pref.resource_id,
           PrefRegistrySyncable::UNSYNCABLE_PREF);
       fonts_with_defaults.insert(pref.pref_name);
     }
   }
 
   // Register font prefs that don't have defaults.
-  RegisterFontFamilyMap(registry, prefs::kWebKitStandardFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitFixedFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitSerifFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitSansSerifFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitCursiveFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitFantasyFontFamilyMap,
-                        fonts_with_defaults);
-  RegisterFontFamilyMap(registry, prefs::kWebKitPictographFontFamilyMap,
-                        fonts_with_defaults);
+  RegisterFontFamilyMap(registry, fonts_with_defaults);
 
   registry->RegisterLocalizedIntegerPref(prefs::kWebKitDefaultFontSize,
                                          IDS_DEFAULT_FONT_SIZE,
                                          PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterLocalizedIntegerPref(prefs::kWebKitDefaultFixedFontSize,
                                          IDS_DEFAULT_FIXED_FONT_SIZE,
                                          PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterLocalizedIntegerPref(prefs::kWebKitMinimumFontSize,
                                          IDS_MINIMUM_FONT_SIZE,
                                          PrefRegistrySyncable::UNSYNCABLE_PREF);
@@ skipping 88 matching lines @@
       WebPreferences web_prefs =
           web_contents_->GetRenderViewHost()->GetWebkitPreferences();
       OverrideFontFamily(&web_prefs, generic_family, script, "");
       web_contents_->GetRenderViewHost()->UpdateWebkitPreferences(web_prefs);
       return;
     }
   }
 
   UpdateWebPreferences();
 }