Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: webkit/media/webmediaplayer_impl.h

Issue 12902002: Remove WebVideoFrame, WebVideoFrameProvider, and WebVideoLayer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: No provider client lock Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_impl.h
diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
index 2826e9074e407218cafca43dfd8c45e645d31b66..11a948fc6405c196e1c255973e8c2c20d3ab815f 100644
--- a/webkit/media/webmediaplayer_impl.h
+++ b/webkit/media/webmediaplayer_impl.h
@@ -26,6 +26,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/threading/thread.h"
+#include "cc/layers/video_frame_provider.h"
#include "googleurl/src/gurl.h"
#include "media/base/audio_renderer_sink.h"
#include "media/base/decryptor.h"
@@ -54,6 +55,10 @@ class ChunkDemuxer;
class MediaLog;
}
+namespace webkit {
+class WebLayerImpl;
+}
+
namespace webkit_media {
class BufferedDataSource;
@@ -64,6 +69,7 @@ class WebMediaPlayerParams;
class WebMediaPlayerImpl
: public WebKit::WebMediaPlayer,
+ public cc::VideoFrameProvider,
public MessageLoop::DestructionObserver,
public base::SupportsWeakPtr<WebMediaPlayerImpl> {
public:
@@ -141,8 +147,12 @@ class WebMediaPlayerImpl
virtual unsigned audioDecodedByteCount() const;
virtual unsigned videoDecodedByteCount() const;
- virtual WebKit::WebVideoFrame* getCurrentFrame();
- virtual void putCurrentFrame(WebKit::WebVideoFrame* web_video_frame);
+ // cc::VideoFrameProvider implementation.
+ virtual void SetVideoFrameProviderClient(
+ cc::VideoFrameProvider::Client* client) OVERRIDE;
+ virtual scoped_refptr<media::VideoFrame> GetCurrentFrame() OVERRIDE;
+ virtual void PutCurrentFrame(const scoped_refptr<media::VideoFrame>& frame)
+ OVERRIDE;
virtual bool copyVideoTextureToPlatformTexture(
WebKit::WebGraphicsContext3D* web_graphics_context,
@@ -341,6 +351,10 @@ class WebMediaPlayerImpl
scoped_refptr<media::VideoFrame> current_frame_;
bool pending_repaint_;
+ scoped_ptr<webkit::WebLayerImpl> video_weblayer_;
+
+ cc::VideoFrameProvider::Client* video_frame_provider_client_;
jamesr 2013/03/21 00:59:11 could use some member comments here - at least ind
danakj 2013/03/21 03:05:26 Done.
+
DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698