Issue 1290193003: Align PreParser for loop early error-checking with Parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290193003: Align PreParser for loop early error-checking with Parser (Closed)

Created:
5 years, 4 months ago by adamk

Modified:
5 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Align PreParser for loop early error-checking with Parser R=rossberg@chromium.org Committed: https://crrev.com/092b4317b2a846dbe00d663f524c54ab7d767afb Cr-Commit-Position: refs/heads/master@{#30168}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -2 lines)			Patch
M	src/preparser.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
A	test/message/for-loop-invalid-lhs.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/message/for-loop-invalid-lhs.out	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290193003/1

5 years, 4 months ago (2015-08-13 19:09:34 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-13 19:11:19 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/092b4317b2a846dbe00d663f524c54ab7d767afb
Cr-Commit-Position: refs/heads/master@{#30168}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages