Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1290183002: Drop an obsolete Keychain disclaimer in the import dialog. (Closed)

Created:
5 years, 4 months ago by vasilii
Modified:
5 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tfarina, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop an obsolete Keychain disclaimer in the import dialog. BUG=466638 Committed: https://crrev.com/60cde74a6d0f3f5d1caf769b9b2604d3bc2b7dc3 Cr-Commit-Position: refs/heads/master@{#343354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.js View 4 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vasilii
Hi Dan, please review the CL.
5 years, 4 months ago (2015-08-13 17:26:27 UTC) #2
Dan Beam
lgtm
5 years, 4 months ago (2015-08-13 18:36:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290183002/1
5 years, 4 months ago (2015-08-14 08:25:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 08:54:48 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 08:55:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60cde74a6d0f3f5d1caf769b9b2604d3bc2b7dc3
Cr-Commit-Position: refs/heads/master@{#343354}

Powered by Google App Engine
This is Rietveld 408576698