Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290173003: [Android] Reland of Remove android_commands and android_testrunner. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
CC:
bruening+watch_chromium.org, chromium-reviews, craigdh, glider+watch_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, perezju, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Reland of Remove android_commands and android_testrunner. Original CL: https://codereview.chromium.org/1290773009/ Revert: https://codereview.chromium.org/1288993002/ BUG=267773 TBR=thakis@chromium.org,maruel@chromium.org Committed: https://crrev.com/cd661e4ff1097b6916891a99ec9654e39e265fba Cr-Commit-Position: refs/heads/master@{#343257}

Patch Set 1 : original: https://codereview.chromium.org/1290773009/ #

Patch Set 2 : fixed: removed references from content/telemetry.isolate and TELEMETRY_DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3733 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +1 line, -3 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +5 lines, -2 lines 0 comments Download
M build/android/provision_devices.py View 2 chunks +1 line, -7 lines 0 comments Download
D build/android/pylib/android_commands.py View 1 chunk +0 lines, -1976 lines 0 comments Download
D build/android/pylib/android_commands_unittest.py View 1 chunk +0 lines, -191 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/pylib/device/decorators.py View 2 chunks +0 lines, -12 lines 0 comments Download
M build/android/pylib/device/decorators_test.py View 5 chunks +0 lines, -77 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 2 chunks +0 lines, -7 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 3 chunks +0 lines, -12 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 3 chunks +13 lines, -4 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
D build/android/pylib/system_properties.py View 1 chunk +0 lines, -40 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 1 chunk +0 lines, -4 lines 0 comments Download
M content/telemetry.isolate View 1 1 chunk +0 lines, -1 line 0 comments Download
D third_party/android_testrunner/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/android_testrunner/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/android_testrunner/README.chromium View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/android_testrunner/adb_interface.py View 1 chunk +0 lines, -522 lines 0 comments Download
D third_party/android_testrunner/am_instrument_parser.py View 1 chunk +0 lines, -169 lines 0 comments Download
D third_party/android_testrunner/errors.py View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/android_testrunner/logger.py View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/android_testrunner/patch.diff View 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/android_testrunner/run_command.py View 1 chunk +0 lines, -192 lines 0 comments Download
M tools/android/appstats.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/cygprofile/profile_android_startup.py View 7 chunks +20 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jbudorick
5 years, 4 months ago (2015-08-13 17:25:18 UTC) #2
nednguyen
On 2015/08/13 17:25:18, jbudorick wrote: lgtm
5 years, 4 months ago (2015-08-13 17:28:58 UTC) #3
jbudorick
TBR: thakis for third_party/ (unchanged from original CL) maruel for content/telemetry.isolate (trivial)
5 years, 4 months ago (2015-08-13 17:30:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290173003/20001
5 years, 4 months ago (2015-08-13 17:30:42 UTC) #7
M-A Ruel
On 2015/08/13 17:30:32, jbudorick wrote: > TBR: > thakis for third_party/ (unchanged from original CL) ...
5 years, 4 months ago (2015-08-13 17:35:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 19:34:03 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 19:34:45 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cd661e4ff1097b6916891a99ec9654e39e265fba
Cr-Commit-Position: refs/heads/master@{#343257}

Powered by Google App Engine
This is Rietveld 408576698