Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1290153002: Switch android to build with safe_browsing=3 mode. (Closed)

Created:
5 years, 4 months ago by Nathan Parker
Modified:
5 years, 4 months ago
Reviewers:
scottmg, mattm
CC:
chromium-reviews, mattm, acleung1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch android to build with safe_browsing=3 mode, now that the required GMSCore client lib has landed. This compiles in the support for safe browsing, but functionality is gated by the AndroidSafeBrowsing field trial that is disabled by default. BUG=474608 Committed: https://crrev.com/1587e02948b25f38f4fb9ecfdec715e3d8e18711 Cr-Commit-Position: refs/heads/master@{#343306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Nathan Parker
I'll submit this after landing a fix to the clank gyp in https://chrome-internal-review.googlesource.com/#/c/227165
5 years, 4 months ago (2015-08-13 21:17:45 UTC) #2
mattm
lgtm
5 years, 4 months ago (2015-08-13 21:23:56 UTC) #4
scottmg
lgtm
5 years, 4 months ago (2015-08-13 21:31:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290153002/1
5 years, 4 months ago (2015-08-13 23:13:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 23:53:14 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 23:53:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1587e02948b25f38f4fb9ecfdec715e3d8e18711
Cr-Commit-Position: refs/heads/master@{#343306}

Powered by Google App Engine
This is Rietveld 408576698