Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1290133002: SkImage-ify DragImage (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
Reviewers:
Justin Novosad, reed1
CC:
blink-reviews, dcheng
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SkImage-ify DragImage Rework DragImage using the SkImage API. Significant bits: * get rid of Image::deprecatedBitmapCurrentFrame callers, convert to Image::imageForCurrentFrame * consolidate the currently distinct DragImage passes (create, fitToMaxSize, dissolveToFraction) into a single pass (this can avoid several unneeded copies) * implement the above using Skia SkSurface/SkCanvas primitives (instead of ImageOperations::Resize and direct pixel RAM poking) * avoid unneeded rasterization in LocalFrame::paintIntoDragImage() - return an SkPictureImageGenerator-backed Image instead * also remove an unneeded clip and related plumbing in LocalFrame::paintIntoDragImage() BUG=449197 R=reed@google.com,junov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200605

Patch Set 1 #

Patch Set 2 : v2 #

Patch Set 3 : unit test fix #

Patch Set 4 : more unit test fixes, cleanup #

Patch Set 5 : selection opacity fix #

Patch Set 6 : expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -118 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 4 6 chunks +16 lines, -16 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Source/platform/DragImage.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
M Source/platform/DragImage.cpp View 1 2 3 5 chunks +78 lines, -77 lines 0 comments Download
M Source/platform/DragImageTest.cpp View 1 2 3 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
f(malita)
A couple of trivial rebaselines due to minor differences in Chromium vs. Skia image filtering: ...
5 years, 4 months ago (2015-08-14 14:34:45 UTC) #2
Justin Novosad
lgtm I like this SkImage::NewFromPicture business. You are giving me ideas for 2D canvas...
5 years, 4 months ago (2015-08-14 18:08:59 UTC) #3
f(malita)
On 2015/08/14 18:08:59, Justin Novosad wrote: > I like this SkImage::NewFromPicture business. You are giving ...
5 years, 4 months ago (2015-08-14 19:09:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290133002/100001
5 years, 4 months ago (2015-08-14 19:10:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/90841)
5 years, 4 months ago (2015-08-14 20:05:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290133002/100001
5 years, 4 months ago (2015-08-14 20:22:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93545)
5 years, 4 months ago (2015-08-14 22:53:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290133002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290133002/100001
5 years, 4 months ago (2015-08-15 10:20:51 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 11:26:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200605

Powered by Google App Engine
This is Rietveld 408576698