Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1290093003: [MD settings] fix for missing certificate manager string (Closed)

Created:
5 years, 4 months ago by dschuyler
Modified:
5 years, 4 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] fix for missing certificate manager string BUG=425627 Committed: https://crrev.com/be57418ebefe5debb8ddb6625bcba5bf5d3f2ae1 Cr-Commit-Position: refs/heads/master@{#343418}

Patch Set 1 #

Patch Set 2 : fix for reversed strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dschuyler
It's tiny, and it's strings.
5 years, 4 months ago (2015-08-13 19:25:33 UTC) #2
James Hawkins
lgtm
5 years, 4 months ago (2015-08-14 16:33:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290093003/20001
5 years, 4 months ago (2015-08-14 16:55:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 17:30:10 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 17:30:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be57418ebefe5debb8ddb6625bcba5bf5d3f2ae1
Cr-Commit-Position: refs/heads/master@{#343418}

Powered by Google App Engine
This is Rietveld 408576698