Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1290053002: Revert of Group lexical context variables for faster look up. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Group lexical context variables for faster look up. (patchset #2 id:20001 of https://codereview.chromium.org/1281883002/ ) Reason for revert: This performance hack is no longer necessary. Original issue's description: > Group lexical context variables for faster look up. > > Currently, looking up a lexical context variable requires looking up > the variable name and then checking its mode. This can be a bottleneck > in Runtime_DeclareGlobals, even when no lexical context variables are > declared. > > R=rossberg@chromium.org > BUG=crbug:517778 > LOG=N > > Committed: https://crrev.com/a45ed17bb6aca02e940f13bbf456d660cccc86ae > Cr-Commit-Position: refs/heads/master@{#30075} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=crbug:517778 Committed: https://crrev.com/3b18958be5ffed30dd3be19c2776e5bfd9fa488c Cr-Commit-Position: refs/heads/master@{#30145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -75 lines) Patch
M src/contexts.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/contexts.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M src/scopeinfo.cc View 5 chunks +1 line, -38 lines 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Group lexical context variables for faster look up.
5 years, 4 months ago (2015-08-13 06:55:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290053002/1
5 years, 4 months ago (2015-08-13 06:56:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 06:56:35 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 06:56:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b18958be5ffed30dd3be19c2776e5bfd9fa488c
Cr-Commit-Position: refs/heads/master@{#30145}

Powered by Google App Engine
This is Rietveld 408576698