Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1290033003: Rename is_chromeos in libjingle. (Closed)

Created:
5 years, 4 months ago by Peter Mayo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename is_chromeos in libjingle. is_chromeos does a poor job of distinguishing developer builds of chrome for chromeos for your desktop, and chrome for chromeos on a device (where the runtimes are non local, for example) Split this into is_chromeos_ui and is_chromeos_os. BUG=519943 TEST=ChromiumOS compiles equivalently.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libjingle/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Mayo
Dependent on https://codereview.chromium.org/1283313004/ upload suggested kjellander@ as a reviewer. git-cl picks on tommi@
5 years, 4 months ago (2015-08-13 01:24:17 UTC) #1
tommi (sloooow) - chröme
lgtm. kjellander is currently ooo fyi
5 years, 4 months ago (2015-08-13 08:36:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290033003/1
5 years, 4 months ago (2015-08-14 10:18:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/69226)
5 years, 4 months ago (2015-08-14 10:21:09 UTC) #7
Peter Mayo
5 years, 4 months ago (2015-08-14 16:37:36 UTC) #8
On 2015/08/14 10:21:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

This patch is dependent on https://codereview.chromium.org/1283313004/

No CQ until that is finalized and landed.

Powered by Google App Engine
This is Rietveld 408576698