Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 129003003: Remove support for specifying version on command line. (Closed)

Created:
6 years, 11 months ago by grt (UTC plus 2)
Modified:
6 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Remove support for specifying version on command line. This was added for the sake of Chrome Frame and is now no longer needed. BUG=316496 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244197

Patch Set 1 #

Patch Set 2 : sync to r244153 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -50 lines) Patch
M chrome/app/client_util.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
grt (UTC plus 2)
To land after https://codereview.chromium.org/126143005/. Thanks.
6 years, 11 months ago (2014-01-08 19:35:09 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 11 months ago (2014-01-09 21:59:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/129003003/1
6 years, 11 months ago (2014-01-10 14:10:33 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-10 14:10:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/129003003/70001
6 years, 11 months ago (2014-01-10 14:23:11 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/common/chrome_switches.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-10 14:23:14 UTC) #6
grt (UTC plus 2)
On 2014/01/10 14:23:14, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 11 months ago (2014-01-10 14:25:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/129003003/70001
6 years, 11 months ago (2014-01-10 15:30:56 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 17:58:16 UTC) #9
Message was sent while issue was closed.
Change committed as 244197

Powered by Google App Engine
This is Rietveld 408576698