Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile.dart

Issue 1290023002: Hide empty CPU profile on class page (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile.dart
diff --git a/runtime/observatory/lib/src/elements/cpu_profile.dart b/runtime/observatory/lib/src/elements/cpu_profile.dart
index 93ece6626f651f68496b6fc9ed7393ec294b5c2c..97d1fc56c26576a4b49b8f6438b249797714477d 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile.dart
+++ b/runtime/observatory/lib/src/elements/cpu_profile.dart
@@ -559,6 +559,7 @@ class StackTraceTreeConfigElement extends ObservatoryElement {
}
Function onTreeConfigChange;
+ @observable bool show = true;
@observable bool showModeSelector = true;
@observable bool showDirectionSelector = true;
@observable String modeSelector = 'Function';
@@ -1125,6 +1126,7 @@ class CpuProfileTreeElement extends ObservatoryElement {
TableTree codeTree;
TableTree functionTree;
FunctionCallTreeNodeFilter functionFilter;
+ @observable bool show = true;
CpuProfileTreeElement.created() : super.created();
@@ -1132,6 +1134,12 @@ class CpuProfileTreeElement extends ObservatoryElement {
_updateView();
}
+ showChanged(oldValue) {
+ var treeTable = shadowRoot.querySelector('#treeTable');
+ assert(treeTable != null);
+ treeTable.style.display = show ? 'table' : 'none';
+ }
+
void _updateView() {
if (functionTree != null) {
functionTree.clear();
« no previous file with comments | « runtime/observatory/lib/src/elements/class_view.dart ('k') | runtime/observatory/lib/src/elements/cpu_profile.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698