Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290013003: This patch removes all files, directories, flags, and code related to SurfaceWorker, which is now d… (Closed)

Created:
5 years, 4 months ago by paulmeyer
Modified:
5 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch removes all files, directories, flags, and code related to SurfaceWorker, which is now dead. Committed: https://crrev.com/b1d5f28139d07ec521661333ff356bf286bd147c Cr-Commit-Position: refs/heads/master@{#343909}

Patch Set 1 #

Patch Set 2 : Removed SurvaceView code as well. #

Patch Set 3 : Removed entry from _api_features.json . #

Patch Set 4 : One more deletion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -293 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_manager_delegate.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D extensions/browser/guest_view/surface_worker/surface_worker_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D extensions/browser/guest_view/surface_worker/surface_worker_constants.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/browser/guest_view/surface_worker/surface_worker_guest.h View 1 chunk +0 lines, -49 lines 0 comments Download
D extensions/browser/guest_view/surface_worker/surface_worker_guest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/api/surface_worker_internal.json View 1 chunk +0 lines, -10 lines 0 comments Download
M extensions/common/feature_switch.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/feature_switch.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/extensions.gypi View 1 2 chunks +0 lines, -5 lines 0 comments Download
M extensions/extensions_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 4 chunks +0 lines, -14 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_deny.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D extensions/renderer/resources/guest_view/surface_view/surface_view.js View 1 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
paulmeyer
+kalman@ for extensions/ +sky@ for chrome/
5 years, 4 months ago (2015-08-17 19:03:58 UTC) #2
Fady Samuel
What about javascript code?
5 years, 4 months ago (2015-08-17 19:05:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290013003/1
5 years, 4 months ago (2015-08-17 19:05:20 UTC) #6
paulmeyer
On 2015/08/17 19:05:13, Fady Samuel wrote: > What about javascript code? Right, I missed that. ...
5 years, 4 months ago (2015-08-17 19:13:58 UTC) #7
not at google - send to devlin
also need feature files
5 years, 4 months ago (2015-08-17 19:24:11 UTC) #8
paulmeyer
On 2015/08/17 19:24:11, kalman wrote: > also need feature files Done.
5 years, 4 months ago (2015-08-17 19:48:00 UTC) #9
not at google - send to devlin
I also found a reference to surface worker in guest_view_deny, but other than that lgtm.
5 years, 4 months ago (2015-08-17 20:29:36 UTC) #10
sky
LGTM
5 years, 4 months ago (2015-08-17 20:47:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290013003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290013003/60001
5 years, 4 months ago (2015-08-17 22:35:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99349)
5 years, 4 months ago (2015-08-18 01:06:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290013003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290013003/60001
5 years, 4 months ago (2015-08-18 13:21:45 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-18 13:52:13 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 13:53:13 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b1d5f28139d07ec521661333ff356bf286bd147c
Cr-Commit-Position: refs/heads/master@{#343909}

Powered by Google App Engine
This is Rietveld 408576698