Issue 1290005: Adding platform_DiskIterate to the buildverify step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1290005: Adding platform_DiskIterate to the buildverify step (Closed)

Created:
10 years, 9 months ago by dhg

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa

Visibility:
Public.

Description

Adding platform_DiskIterate to the buildverify step

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	server/site_tests/suite_BuildVerify/control	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 9 months ago (2010-03-25 16:22:10 UTC) #2

LGTM (assuming you've tried running)

On Thu, Mar 25, 2010 at 9:00 AM,  <dhg@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Adding platform_DiskIterate to the buildverify step
>
> Please review this at http://codereview.chromium.org/1290005
>
> Affected files:
>  M server/site_tests/suite_BuildVerify/control
>
>
> Index: server/site_tests/suite_BuildVerify/control
> diff --git a/server/site_tests/suite_BuildVerify/control
> b/server/site_tests/suite_BuildVerify/control
> index
>
6f7a02d066385f6f73e805c6e4b4da77a877f664..3eb9aa1b65c61fe6d4e20b46c532b392aaea7e0e
> 100644
> --- a/server/site_tests/suite_BuildVerify/control
> +++ b/server/site_tests/suite_BuildVerify/control
> @@ -45,6 +45,7 @@ TESTS = [
>   'network_WiFiCaps',
>   'platform_AccurateTime',
>   'platform_DaemonsRespawn',
> +  'platform_DiskIterate',
>   'platform_FilePerms',
>   'platform_KernelVersion',
>   'platform_NoOpenFilesAtShutdown',
>
>
>

Expand Messages | Collapse Messages