Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 128993004: Fix subtle bug with the in-process utility thread usage in unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_updater_unittest.cc
===================================================================
--- chrome/browser/extensions/updater/extension_updater_unittest.cc (revision 243741)
+++ chrome/browser/extensions/updater/extension_updater_unittest.cc (working copy)
@@ -46,7 +46,6 @@
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_source.h"
-#include "content/public/browser/render_process_host.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "content/public/test/test_utils.h"
#include "extensions/common/extension.h"
@@ -494,7 +493,6 @@
virtual void SetUp() OVERRIDE {
prefs_.reset(new TestExtensionPrefs(base::MessageLoopProxy::current()));
- content::RenderProcessHost::SetRunRendererInProcess(true);
}
virtual void TearDown() OVERRIDE {
@@ -503,7 +501,6 @@
// those objects are released.
RunUntilIdle();
prefs_.reset();
- content::RenderProcessHost::SetRunRendererInProcess(false);
}
void RunUntilIdle() {
@@ -1393,6 +1390,7 @@
private:
content::TestBrowserThreadBundle thread_bundle_;
+ content::InProcessUtilityThreadHelper in_process_utility_thread_helper_;
#if defined OS_CHROMEOS
chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;

Powered by Google App Engine
This is Rietveld 408576698