Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289923004: Change the HSTS preload entry for carbonmade.com to include_subdomains: false. (Closed)

Created:
5 years, 4 months ago by lgarron
Modified:
5 years, 4 months ago
Reviewers:
agl
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the HSTS preload entry for carbonmade.com to include_subdomains: false. BUG=518717 TBR=agl@chromium.org Committed: https://crrev.com/610263c91f62135511f6ca249e12accffae6f20a Cr-Commit-Position: refs/heads/master@{#343185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/http/transport_security_state_static.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/transport_security_state_static.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
lgarron
TBR because of https://code.google.com/p/chromium/issues/detail?id=518717#c5 and because you've encouraged me to TBR preload list stuff. Lemme ...
5 years, 4 months ago (2015-08-13 04:26:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289923004/1
5 years, 4 months ago (2015-08-13 04:27:00 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-13 04:27:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289923004/1
5 years, 4 months ago (2015-08-13 04:29:10 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-13 04:29:11 UTC) #10
agl
lgtm TBR is fine (when it works!)
5 years, 4 months ago (2015-08-13 11:12:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289923004/1
5 years, 4 months ago (2015-08-13 11:12:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 12:52:03 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 12:52:38 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/610263c91f62135511f6ca249e12accffae6f20a
Cr-Commit-Position: refs/heads/master@{#343185}

Powered by Google App Engine
This is Rietveld 408576698