media/formats/mp4/box_definitions.h - Issue 1289923003: Refactor AnnexB bitstream conversion for AVC/H.264

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/box_definitions.h

Issue 1289923003: Refactor AnnexB bitstream conversion for AVC/H.264 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@annexb-avc-fix

Patch Set: Added a few comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp4/box_definitions.h

diff --git a/media/formats/mp4/box_definitions.h b/media/formats/mp4/box_definitions.h

index e932dc577de9c0443227e8b42bc0f074639f8e55..666ad7e2115c2441e45350da2bb0bceb1aa0d11f 100644

--- a/media/formats/mp4/box_definitions.h

+++ b/media/formats/mp4/box_definitions.h

@@ -207,10 +207,9 @@ struct MEDIA_EXPORT VideoSampleEntry : Box {

PixelAspectRatioBox pixel_aspect;

ProtectionSchemeInfo sinf;

- // Currently expected to be present regardless of format.

- AVCDecoderConfigurationRecord avcc;

bool IsFormatValid() const;

+ scoped_refptr<BitstreamConverter> frame_bitstream_converter;

};

struct MEDIA_EXPORT ElementaryStreamDescriptor : Box {

« no previous file with comments | « media/formats/mp4/bitstream_converter.cc ('k') | media/formats/mp4/box_definitions.cc » ('j') | no next file with comments »