Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1289923003: Refactor AnnexB bitstream conversion for AVC/H.264 (Closed)

Created:
5 years, 4 months ago by servolk
Modified:
5 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, wolenetz, ddorwin
Base URL:
https://chromium.googlesource.com/chromium/src.git@annexb-avc-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor AnnexB bitstream conversion for AVC/H.264 Having an explicit bitstream converter interface will allow us to move AnnexB conversion code (PrepareAVCBuffer) from mp4_stream_parser.cc into avc.cc, resulting in cleaner separation of generic mp4 parser code and codec-specific parts. Which has two advantages: 1. It will simplify HEVC integration by removing HEVC specific code from public interfaces and might eventually allow us to toggle HEVC with a local gyp/gn flag and get rid of the global define that has caused a lot of contention in the current version of HEVC CL. 2. After some additional work we should be able to unify AnnexB bitstream conversion code, which is currently duplicated between MSE and FFmpeg code paths (see crbug.com/455379). BUG=455379 Committed: https://crrev.com/b199d3440e7b516c98cae679e779af9f5670ef44 Cr-Commit-Position: refs/heads/master@{#343818}

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Patch Set 3 : BitstreamConverter doesn't need to have MEDIA_EXPORT #

Total comments: 4

Patch Set 4 : Added a few comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -38 lines) Patch
M media/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M media/formats/mp4/avc.h View 1 2 3 2 chunks +20 lines, -0 lines 0 comments Download
M media/formats/mp4/avc.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
A media/formats/mp4/bitstream_converter.h View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A + media/formats/mp4/bitstream_converter.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M media/formats/mp4/box_definitions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 2 chunks +3 lines, -25 lines 0 comments Download
M media/media.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
servolk
5 years, 4 months ago (2015-08-14 02:35:20 UTC) #2
sandersd (OOO until July 31)
https://codereview.chromium.org/1289923003/diff/40001/media/formats/mp4/avc.h File media/formats/mp4/avc.h (right): https://codereview.chromium.org/1289923003/diff/40001/media/formats/mp4/avc.h#newcode62 media/formats/mp4/avc.h:62: class AVCBitstreamConverter : public BitstreamConverter { Comment exact what ...
5 years, 4 months ago (2015-08-17 18:24:07 UTC) #5
servolk
https://codereview.chromium.org/1289923003/diff/40001/media/formats/mp4/avc.h File media/formats/mp4/avc.h (right): https://codereview.chromium.org/1289923003/diff/40001/media/formats/mp4/avc.h#newcode62 media/formats/mp4/avc.h:62: class AVCBitstreamConverter : public BitstreamConverter { On 2015/08/17 18:24:07, ...
5 years, 4 months ago (2015-08-17 22:06:24 UTC) #6
sandersd (OOO until July 31)
lgtm
5 years, 4 months ago (2015-08-17 22:15:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289923003/60001
5 years, 4 months ago (2015-08-17 22:17:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99318)
5 years, 4 months ago (2015-08-18 00:58:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289923003/60001
5 years, 4 months ago (2015-08-18 01:11:51 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-18 05:20:29 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:21:19 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b199d3440e7b516c98cae679e779af9f5670ef44
Cr-Commit-Position: refs/heads/master@{#343818}

Powered by Google App Engine
This is Rietveld 408576698