Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1289903002: Normalize SkXfermode_opts.h argument order as d,s[,aa]. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Normalize SkXfermode_opts.h argument order as d,s[,aa]. At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa] so we ended up having to write weird little lambda shims to match impedance. There's no reason for these to disagree, and d,s[,aa] is the One True Order (because no matter what you're doing in graphics, there's always a dst). Should be no perf or image diff, though I'm suspicious it might help MSVC code generation. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot Committed: https://skia.googlesource.com/skia/+/5a16cf654548190841b5af27af04e7995582ad7b

Patch Set 1 #

Patch Set 2 : floats first #

Patch Set 3 : now sk4px #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M src/opts/SkXfermode_opts.h View 1 2 3 5 chunks +13 lines, -23 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
5 years, 4 months ago (2015-08-12 17:30:18 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-12 17:36:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 17:37:10 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-08-12 17:49:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
5 years, 4 months ago (2015-08-12 17:51:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f
5 years, 4 months ago (2015-08-12 17:52:28 UTC) #10
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1284363002/ by mtklein@google.com. ...
5 years, 4 months ago (2015-08-12 20:51:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
5 years, 4 months ago (2015-08-13 15:38:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/20001
5 years, 4 months ago (2015-08-13 17:26:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/20001
5 years, 4 months ago (2015-08-13 19:14:34 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5a16cf654548190841b5af27af04e7995582ad7b
5 years, 4 months ago (2015-08-13 20:10:33 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/60001
5 years, 4 months ago (2015-08-13 20:45:34 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot/builds/7)
5 years, 4 months ago (2015-08-13 23:30:33 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/80001
5 years, 4 months ago (2015-08-18 19:24:34 UTC) #30
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 21:42:30 UTC) #32
Try jobs failed on following builders:
  Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleB-CPU-...)

Powered by Google App Engine
This is Rietveld 408576698