|
|
DescriptionNormalize SkXfermode_opts.h argument order as d,s[,aa].
At head they're s,d[,aa] in SkXfermode_opts.h but Sk4px::Map* expect d,s[,aa]
so we ended up having to write weird little lambda shims to match impedance.
There's no reason for these to disagree, and d,s[,aa] is the One True Order
(because no matter what you're doing in graphics, there's always a dst).
Should be no perf or image diff, though I'm suspicious it might help MSVC code generation.
BUG=skia:4117
Committed: https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f
CQ_EXTRA_TRYBOTS=client.skia:Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot
Committed: https://skia.googlesource.com/skia/+/5a16cf654548190841b5af27af04e7995582ad7b
Patch Set 1 #Patch Set 2 : floats first #Patch Set 3 : now sk4px #Patch Set 4 : rebase #Messages
Total messages: 32 (17 generated)
The CQ bit was checked by mtklein@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
mtklein@chromium.org changed reviewers: + djsollen@google.com - mtklein@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6028a8476504022fe40b6870b1460b5e4a80969f
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1284363002/ by mtklein@google.com. The reason for reverting is: ?.
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/1
The CQ bit was unchecked by mtklein@chromium.org
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1289903002/#ps20001 (title: "floats first")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/20001
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1289903002/#ps20001 (title: "floats first")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5a16cf654548190841b5af27af04e7995582ad7b
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1289903002/#ps60001 (title: "now sk4px")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleB-CPU-...)
The CQ bit was checked by mtklein@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1289903002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289903002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Win8-MSVC-ShuttleB-CPU-...) |