Issue 1289863002: Revert of SkPDF: Move SkFlate into src/pdf (part 1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1289863002: Revert of SkPDF: Move SkFlate into src/pdf (part 1/3) (Closed)

Created:
5 years, 4 months ago by hal.canary

Modified:
5 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org, reed1

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of SkPDF: Move SkFlate into src/pdf (part 1/3) (patchset #1 id:1 of https://codereview.chromium.org/1285913002/ ) Reason for revert: broke gn ("Duplicate object file") Original issue's description: > SkPDF: Move SkFlate into src/pdf (part 1/3) > > Next, we change Chromium build files, then we do the actual move. > > Committed: https://skia.googlesource.com/skia/+/e14c1fe04fc72ec9bcf55820b5c65a71d7d0a764 TBR=bungeman@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/cc34c41326ae53689d5f88bce7b4b17375a74df9

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -4 lines)			Patch
M	gyp/pdf.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/pdf.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
A	gyp/skflate.gyp	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hal.canary

Created Revert of SkPDF: Move SkFlate into src/pdf (part 1/3)

5 years, 4 months ago (2015-08-12 15:52:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289863002/1

5 years, 4 months ago (2015-08-12 15:53:00 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-12 15:53:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc34c41326ae53689d5f88bce7b4b17375a74df9

Expand Messages | Collapse Messages