Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1289823008: Reland #1: Add a short term solution to fix OSX 10.11 system font rendering problems. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
tkent, keishi, yurys
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland #1: Add a short term solution to fix OSX 10.11 system font rendering problems. I forgot to update the test FontFamilyMatcherMacTest.YosemiteFontWeights. > I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system > font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily() > to correctly return the system font on 10.11, but this causes glyph rendering > problems. In the short term, I'm adding logic to MatchNSFontFamily() to return > nil on 10.11, which was the original behavior before I landed that CL. > > BUG=521034 > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618 BUG=521034 TBR=tkent@chromium.org, keishi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200653

Patch Set 1 : Copy pf patch set 2 of https://codereview.chromium.org/1284993004/ #

Patch Set 2 : Fix Yosemite test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
This is a reland with no behavior changes, just a test fix. TBRing tkent & ...
5 years, 4 months ago (2015-08-17 17:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289823008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289823008/20001
5 years, 4 months ago (2015-08-17 17:07:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200653
5 years, 4 months ago (2015-08-17 17:49:56 UTC) #5
yurys
The change broke several layout tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/2551/steps/webkit_tests/logs/stdio
5 years, 4 months ago (2015-08-17 18:20:47 UTC) #7
erikchen
On 2015/08/17 18:20:47, yurys wrote: > The change broke several layout tests: > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/2551/steps/webkit_tests/logs/stdio ...
5 years, 4 months ago (2015-08-17 18:22:13 UTC) #8
yurys
On 2015/08/17 18:22:13, erikchen wrote: > On 2015/08/17 18:20:47, yurys wrote: > > The change ...
5 years, 4 months ago (2015-08-17 18:24:31 UTC) #9
yurys
5 years, 4 months ago (2015-08-17 18:42:46 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1299723002/ by yurys@chromium.org.

The reason for reverting is: Broke layout tests on Mac 10.10

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds....

Powered by Google App Engine
This is Rietveld 408576698